Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvement: major difference between the behaviour of evaluateJavaScript in PhantomJS VS SlimerJS #702

Open
HouzuoGuo opened this issue Jun 14, 2018 · 0 comments

Comments

@HouzuoGuo
Copy link

versions

  • SlimerJS: 1.0
  • Firefox: 58
  • Operating system: Alpine Linux container

Steps to reproduce the issue

The legacy PhantomJS uses a rather weird convention for evaluateJavaScript function - it asks the script input to be wrapped around function() {}, or the script will not be executed at all. For example:

http://phantomjs.org/api/webpage/method/evaluate-java-script.html

On the other hand, SlimerJS correctly runs the script input without having to wrap them in function() {}, and in fact it correctly reports syntax error.

Please note down this difference in function doc or consolidated differences.

And a big thank you to everyone involved in the development of SlimerJS. PhantomJS left too much legacy in the world of scriptable headless browser, it's very challenging to migrate large chunk of PhantomJS app to chrome headless, yet SlimerJS fills the gap incredibly well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant