-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect number of note items and unused dead area in Note List panel #5178
Comments
The note list expects a fixed note height for performance reasons, so if it's changed via css it won't work. |
@laurent22 , it is possible to configure the height of note list items using CSS without any performance degradation. If the performance is the only thing that matters, it is unnecessary to give up to fix the bug. |
Not using CSS, it can't be done because the list is already built by the time the CSS is applied. I don't have any solution to be honest, it's just the way it works. The list can handle thousands of notes but the drawback is indeed that it's not that flexible. |
It CAN. The height of a note list item specified by CSS can be acquired before the first time of the window of the desktop app is rendered. After that, no extra processes and overheads are needed. |
@laurent22 , do you need a working example? |
PR #5271 fixes this issue. |
@laurent22 , in order to keep the issue tracking clean for the future, if the reason of the previous close were based on misunderstanding, it would be recommended that the close is reverted to the open state and that it will be closed after another decision |
I am actually running into the same problem, current design uses a lot of spacing which is nice to look at but for small laptop i want to pack as much as information as i can. Just to comment to say that i am glad to see that there is a potential fix for it. |
What about instead of CSS this be made an option under Settings -> Appearance?? |
Just had the same problem. I am sad that the issue has been open for so long :( |
To increase the displayed information of Joplin, I reduced the height of note items in the Note List using the following userchrome.css.
The result is as follows. The bottom area of the Note List is unused, and the number of the notes in the list is unchanged before and after the height is changed. For comparison, the Sidebar is properly rendered.
For reference, the before image is here.
Environment
Joplin version: 2.1.8
Platform: Windows
OS specifics: Windows 10 Pro (21H1)
Steps to reproduce
Describe what you expected to happen
When the height of items in the Note List is reduced, the whole area should be used and the number of items should be increased as follows.
The text was updated successfully, but these errors were encountered: