Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In windows dark mode window title bar is white #4971

Closed
zd-dalibor opened this issue May 15, 2021 · 8 comments
Closed

In windows dark mode window title bar is white #4971

zd-dalibor opened this issue May 15, 2021 · 8 comments
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@zd-dalibor
Copy link

Can we have title bar black when windows dark mode is activated.

image

I think all electron apps have this problem but I think it is fixed.
Please check this issue electron/electron#23479

@zd-dalibor zd-dalibor added the bug It's a bug label May 15, 2021
@MRog40
Copy link

MRog40 commented May 18, 2021

Mine is black, try changing AccentColor and AccentColorInactive in regedit at Computer\HKEY_CURRENT_USER\Software\Microsoft\Windows\DWM

Mine:
image

@dz2106
Copy link

dz2106 commented May 18, 2021

Taking a look at this issue

@dz2106
Copy link

dz2106 commented May 18, 2021

So I did some digging. It appears that this feature of Electron is not compatible with prebuilt versions of Electron. There are workarounds such as a custom title bar with an external package that appear to fix the issue.

Setting enable_win_dark_mode_window_ui to true would partially solve the issue if we were to build electron ourselves.

@dz2106
Copy link

dz2106 commented May 19, 2021

Created a forum post on this issue: https://discourse.joplinapp.org/t/windows-dark-title-bar/17442

It seems others have had this concern for sometime now.

@dz2106
Copy link

dz2106 commented May 20, 2021

Looking at the forum responses, it is best to close this issue as no solutions worked with the project goals

@stale
Copy link

stale bot commented Jun 19, 2021

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Jun 19, 2021
@stale
Copy link

stale bot commented Jun 26, 2021

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jun 26, 2021
@jberlyn
Copy link

jberlyn commented May 17, 2023

Can this issue be reopened? It's quite jarring having a light title bar when the entire system is set to dark mode.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

4 participants