Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing HTML with very long links can crash because file name too long #10946

Closed
pedr opened this issue Aug 30, 2024 · 3 comments
Closed

Importing HTML with very long links can crash because file name too long #10946

pedr opened this issue Aug 30, 2024 · 3 comments
Assignees
@pedr
Labels
bug It's a bug desktop All desktop platforms stale An issue that hasn't been active for a while...

Comments

@pedr
Copy link
Collaborator

pedr commented Aug 30, 2024

Operating system

Linux

Joplin version

3.1.4

Desktop version info

Joplin 3.1.4 (dev, linux)

Client ID: f11b9225fa2f40a780ed97ff5ad40316
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: 7d25c00 (skip-creating-resource-from-uris)

Backup: 1.4.2

Current behaviour

  1. Create a HTML file with a link to a local file with a very long file name (>255 characters)
  2. Try to import it as a HTML file
  3. HTML import crashes because the file name is too long (ENAMETOOLONG error)

Expected behaviour

  1. Create a HTML file with a link to a local file with a very long file name (>255 characters)
  2. Try to import it as a HTML file
  3. Import finishes (similar to what happens when the file doesn't exist)

Logs

Example HTML: 
<html>
<body>
    <a href="1234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678.pdf" />
</body>
</html>
@pedr pedr added the bug It's a bug label Aug 30, 2024
@pedr pedr self-assigned this Aug 30, 2024
@pedr pedr added the desktop All desktop platforms label Aug 30, 2024
@pedr pedr mentioned this issue Aug 30, 2024
Closed
@pedr
Copy link
Collaborator Author

pedr commented Sep 4, 2024

The issue is that when we are rendering the onenote to html when the paragraph starts with an specific unicode (0x000B) character, the styles get shifted by one making a text that should be a <span> to become a <a> (by default if a style is a hyperlink it will add the text itself as href). By fixing this here 50c8697 it should address the behaviour reported on this PR/issue.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Oct 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pedr pedr

Labels
bug It's a bug desktop All desktop platforms stale An issue that hasn't been active for a while...
Projects
None yet
Milestone
No milestone
1 participant
@pedr