Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benign drift on fallthrough.rollout_weights #148

Open
nhomble opened this issue May 12, 2023 · 1 comment
Open

benign drift on fallthrough.rollout_weights #148

nhomble opened this issue May 12, 2023 · 1 comment

Comments

@nhomble
Copy link

nhomble commented May 12, 2023

Using provider version 2.0

We see that terraform detects drift from our LD instance because fallthrough.rollout_weights becomes []. To avoid the noise in detection, I think the provider could handle nil better instead of waiting for the reconciliation.

My best guess is that https://github.com/launchdarkly/terraform-provider-launchdarkly/blob/main/launchdarkly/fallthrough_helper.go#L73 could be enhanced to default to [] before the percent rollout check.

@ldhenry
Copy link
Collaborator

ldhenry commented May 26, 2023

Hey @nhomble,

Thanks for bringing this to our attention. I've created an internal ticket to investigate a solution. We'll be sure to update this issue as we learn more.

Thanks,
Henry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants