Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Unable to compile with Webpack. #143

Closed
aceofpack opened this issue Feb 28, 2019 · 1 comment
Closed

Unable to compile with Webpack. #143

aceofpack opened this issue Feb 28, 2019 · 1 comment

Comments

@aceofpack
Copy link

When I tested LD in a dummy repo it ran perfectly fine. I've now included it in our product but webpack will not compile it with many package errors - for example:

ERROR in ../node_modules/ldclient-node/file_data_source.js
Module not found: Error: Can't resolve 'fs' in '/Users/me/Repos/fluidly-web/node_modules/ldclient-node'

There are some ideas how to sort this here:

webpack/webpack#744

Specifically:

The proper course is the ask the module author to make the module browser compatible. 
The author can add `browser: { fs: false, child_process: false }` to the `package.json` to tell webpack that it's ok for the module to get an empty object for these modules.
@aceofpack
Copy link
Author

Ok, I'm not sure I wasn't questioning why my webpack was even trying to compile the node version. I've found the reason why and it's fixed. Sorry to cause alarm. Can close the issue.

LaunchDarklyCI pushed a commit that referenced this issue Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant