This repository has been archived by the owner on May 30, 2024. It is now read-only.
updated typescript definitions for LDOptions #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added missing private fields related configuration options - added missing user keys buffer configuration options
|
Thanks for the updates. Is there a way we can check typescript coverage in CI? |
eli-darkly
approved these changes
Jun 5, 2018
|
@ashanbrown I can't think how an automated coverage check could possibly work in this case. These are object properties that aren't defined in any one place in the code. If we were actually writing TypeScript it would be different. |
Merged
eli-darkly
added a commit
that referenced
this pull request
Aug 22, 2018
fix dependencies with npm audit; add npm audit to CI build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description taken from https://docs.launchdarkly.com/docs/node-sdk-reference site.