Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableInternalUsageMetrics has been removed in relay v8 #264

Closed
husseinsakr opened this issue Oct 17, 2023 · 4 comments
Closed

disableInternalUsageMetrics has been removed in relay v8 #264

husseinsakr opened this issue Oct 17, 2023 · 4 comments
Labels
question waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness.

Comments

@husseinsakr
Copy link

Is your feature request related to a problem? Please describe.
In version 8 of ld-relay, disableInternalUsageMetrics was deprecated. We currently use the launchdarkly relay proxy with it enabled to avoid unnecessary network data sent to launchdarkly. Is it possible to add it back?

Describe the solution you'd like
Re-adding disableInternalUsageMetrics option

Describe alternatives you've considered
N/A

Additional context
N/A

@cwaldren-ld
Copy link
Contributor

Hi @husseinsakr ,

Previously the data collected by the Relay Proxy and sent to LaunchDarkly was only used for internal diagnostic purposes. Because this data wasn’t critical, LaunchDarkly provided a disableInternalUsageMetric Relay Proxy configuration option to allow customers to disable the data publication.

In the near future, this data will have increased importance on the LaunchDarkly platform. As a result, LaunchDarkly removed the option for customers to disable this data’s publication.

@cwaldren-ld cwaldren-ld added question waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness. labels Oct 17, 2023
@cwaldren-ld cwaldren-ld changed the title disableInternalUsageMetrics has been deprcated with relay version 8 disableInternalUsageMetrics has been removed in relay v8 Oct 17, 2023
@husseinsakr
Copy link
Author

husseinsakr commented Oct 17, 2023

Thank you @cwaldren-ld

In the near future, this data will have increased importance on the LaunchDarkly platform. As a result, LaunchDarkly removed the option for customers to disable this data’s publication.

How will this effect the launchdarkly relay proxy in offline mode in the future? Specifically your mentioning of "this data will have increased importance on the LaunchDarkly platform". For our fedramp solution, we use the relay proxy in offline mode which today enables disableInternalUsageMetric.

@cwaldren-ld
Copy link
Contributor

Offline mode will continue to be supported. In offline mode, the internal usage metrics will not be sent to LaunchDarkly.

At this time, the change only affects the default behavior of Relay (not offline), which is to connect to LaunchDarkly for flag data.

To be clear, offline mode and disableInternalUsageMetric could be configured independently and control different things. Offline mode means no connections to LaunchDarkly at all, whereas disableInternalUsageMetric could be used even when connecting to LaunchDarkly to receive flag data.

@husseinsakr
Copy link
Author

Thank you @cwaldren-ld !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness.
Projects
None yet
Development

No branches or pull requests

2 participants