Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup should use the same pool & connection options as the test itself and not DATABASE_URL unconditionally #3247

Open
poliorcetics opened this issue May 29, 2024 · 3 comments

Comments

@poliorcetics
Copy link

poliorcetics commented May 29, 2024

if let Err(e) = DB::cleanup_test(&test_context.db_name).await {

This prevents testing with a local PostgreSQL Unix-domain socket for example

@poliorcetics
Copy link
Author

Workaround found at #1202 (comment)

@poliorcetics
Copy link
Author

Reopening because I think it makes sense to fix the issue even if there is a workaround

@abonander
Copy link
Collaborator

Test cleanup literally deletes the database. It can't use anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants