Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark a bunch of types #[must_use] #173

Closed
abonander opened this issue Mar 29, 2020 · 0 comments · Fixed by #216
Closed

Mark a bunch of types #[must_use] #173

abonander opened this issue Mar 29, 2020 · 0 comments · Fixed by #216
Labels
E-easy enhancement New feature or request good first issue Good for newcomers

Comments

@abonander
Copy link
Collaborator

abonander commented Mar 29, 2020 •
edited
Loading

  • in sqlx-core/src/cursor.rs, the trait Cursor (which should cover implementations): "cursor must have .next() called to execute query"

  • in sqlx-core/src/query.rs, Query and Map: "query must be executed to affect database"

  • in sqlx-core/src/query_as.rs: QueryAs: "query must be executed to affect database"

  • in sqlx-core/src/transaction.rs: Transaction: "transaction rolls back if not explicitly .commit()ed"

@mehcode
@abonander abonander added enhancement New feature or request good first issue Good for newcomers labels Mar 29, 2020
@mehcode mehcode added the E-easy label Mar 29, 2020
@Ace4896 Ace4896 mentioned this issue Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark several types as #[must_use]
2 participants
@mehcode @abonander