time dependency out of date

[OvermindDL1]

The time dependency is currently set to 0.2.16, the latest 0.2 version is 0.2.26, however 0.3.0 has a couple alpha versions out and looks about to be released. I'm using a project where another dependency is using time 0.3.0 latest alpha and I'm unable to pass times between it and sqlx due to the version mismatch. Any chance of either updating time in sqlx to 0.3 alpha or adding a new feature with its support so I don't have to manually (and buggy in some cases) transfer between them?

[abonander]

You can't have multiple versions of the same crate as a direct dependency, optional or not. And anyway, I don't think we want to link against an alpha release, especially not in a public dependency like time as that would be a breaking change every time we upgrade (necessitating a 0.x.0 -> 0.(x + 1).0 version bump), and alpha releases aren't semver-compatible.

The time dependency is currently set to 0.2.16, the latest 0.2 version is 0.2.26,

Even though we specify a patch release like 0.2.16, because of semver that can automatically update to 0.2.26 or later under 0.2.x without our intervention. By default unless you prefix the version with = it's only a minimum.

[jplatte]

You can't have multiple versions of the same crate as a direct dependency, optional or not.

This is not true.

And anyway, I don't think we want to link against an alpha release, [...]

How about this? (personally I don't care about the time alpha version, but if I were a maintainer, I'd accept a patch like this)

# unstable feature: may be removed in a non-breaking release
unstable-time03-alpha1 = { package = "time", version = "=0.3.0-alpha-1", optional = true }

#[cfg(feature = "unstable-time03-alpha1")]
impl Type for unstable_time03_alpha1::Date<unstable_time03_alpha1::Utc> { /* ... */ }

[abonander]

Oh yeah, with a rename you can have multiple of the same crate. My mistake. And all pre-release versions are apparently considered semver-compatible, which is something I keep forgetting: https://doc.rust-lang.org/stable/cargo/reference/resolver.html#pre-releases

Still, I would consider it an antipattern to make an alpha release part of the public API of a non-alpha crate. It looks like a full release of time isn't too far off anyway, so we'll probably just target using time 0.3 for sqlx 0.6.0 (or provide both time-02 and time-03 features, depends on how much of the ecosystem lags behind upgrading): time-rs/time#248 (comment)

[fstephany]

Time 0.3 has been released. Rocket landed a commit with the upgrade but I don't know if others have catched up yet.

[paolobarbolini]

I might have some time available to work on this, if nobody started looking into it yet...

[tyhi]

I might have some time available to work on this, if nobody started looking into it yet...

If you haven't started on it I've been working on it this afternoon, running tests and cleaning then should be able to make a PR.

[abonander]

As it turns out, it's a real pain to support multiple versions of time: #1455 (comment)

It's possible to hack around but the maintenance burden isn't worth it IMO so we're just going to upgrade wholesale to time 0.3 in SQLx 0.6.