Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to specify Athena catalog name in SQLAlchemy connection string #574

Open
YAtOff opened this issue Jan 16, 2025 · 1 comment
Open

Comments

@YAtOff
Copy link

YAtOff commented Jan 16, 2025

I'm setting up the new AWS S3 tables with Athena and Apache Superset.
To use Athena in Superset, I must specify the catalog name in the SQLAlchemy connection string.
This is not possible, but a tiny change, such as adding it to the query string, works.
See: master...YAtOff:PyAthena:feature/sqlalchemy-param-catalog-name

Unless there is a better way, I could make a PR and add the feature to the project.

@laughingman7743
Copy link
Owner

That's strange. If the url contains catalog_name in the line below, it should be set. 🤔
https://github.com/laughingman7743/PyAthena/blob/master/pyathena/sqlalchemy/base.py#L1043

https://github.com/laughingman7743/PyAthena/blob/master/pyathena/sqlalchemy/base.py#L1044-L1059
The part that is being set again in opts is just being converted and set again because the type does not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants