-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(store): optimize table libraries #1303
Conversation
🦋 Changeset detectedLatest commit: 20e5c80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
let's add a small changeset |
a few nuances I feel like I should clarify:
|
We should add a changeset for anything that should trigger a version increase (= stuff that updates code that lands in a user's project, even if it's internal, but not necessarily tests or docs). If the change is an internal refactor or fixes something that was supposed to be working before, it's a For |
changes to 2 files in store's codegen (everything else is autogenerated)
minor stuff to finish table libs
any more attempts at table optimizations likely hurt code too much: #1286 #1183