Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): optimize table libraries #1303

Merged
merged 7 commits into from
Aug 16, 2023
Merged

refactor(store): optimize table libraries #1303

merged 7 commits into from
Aug 16, 2023

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Aug 14, 2023

changes to 2 files in store's codegen (everything else is autogenerated)
minor stuff to finish table libs

any more attempts at table optimizations likely hurt code too much: #1286 #1183

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 20e5c80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/store Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/react Patch
@latticexyz/std-client Patch
@latticexyz/store-cache Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world Patch
@latticexyz/ecs-browser Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/gas-report Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-contracts Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dk1a dk1a mentioned this pull request Aug 15, 2023
15 tasks
@dk1a dk1a changed the title WIP tables gas refactor(store): optimize table libraries Aug 15, 2023
@dk1a dk1a marked this pull request as ready for review August 15, 2023 14:18
@dk1a dk1a requested review from alvrs and holic as code owners August 15, 2023 14:18
holic
holic previously approved these changes Aug 15, 2023
alvrs
alvrs previously approved these changes Aug 16, 2023
@alvrs
Copy link
Member

alvrs commented Aug 16, 2023

let's add a small changeset

@dk1a
Copy link
Contributor Author

dk1a commented Aug 16, 2023

a few nuances I feel like I should clarify:

  • I think we've decided to not do changesets for stuff that's not exported, like tests
  • do we need changesets for internal things (like this gas PR) that are exported but don't affect API/functionality (I guess you could consider gas costs as functionality though)?
  • I assume more detailed changesets for API stuff are good, but do we want details for internal changes?

@alvrs
Copy link
Member

alvrs commented Aug 16, 2023

We should add a changeset for anything that should trigger a version increase (= stuff that updates code that lands in a user's project, even if it's internal, but not necessarily tests or docs). If the change is an internal refactor or fixes something that was supposed to be working before, it's a patch. If it adds a non-breaking feature it's a minor and if it's a breaking change it's a major.

For patch changes a one-liner is totally fine. For new features it depends on the size of the feature, but an example for how to use it is always nice. For breaking changes we need more descriptions for how to update and context on the change.

@dk1a dk1a merged commit d5b73b1 into main Aug 16, 2023
9 checks passed
@dk1a dk1a deleted the dk1a/tables-gas branch August 16, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants