New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert `copy-templates.sh` to a node script #2344

Closed

yonadaaa opened this issue Feb 28, 2024 · 0 comments · Fixed by #3082

Labels

good first issue

Contributor

yonadaaa commented Feb 28, 2024 •

edited by holic

Loading

In trying to support Windows in #2340 we found that templates rely on a bash script that is not portable:
https://github.com/latticexyz/mud/actions/runs/8085328456/job/22092612361?pr=2340#step:4:184

We should use TypeScript scripts instead and without bash commands so this can run on windows

yonadaaa mentioned this issue

chore: test workflow runs with ubuntu and windows OS #2340

Closed

holic added the good first issue label

holic mentioned this issue

Add windows OS to CI runners #2197

Open

holic mentioned this issue

refactor(create-mud): replace bash script with ts #3082

Merged

holic closed this as completed in #3082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment