Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename resourceSelector to tableId and systemId in function signatures for clarity #1367

Closed
alvrs opened this issue Aug 28, 2023 · 1 comment · Fixed by #1544
Closed

Rename resourceSelector to tableId and systemId in function signatures for clarity #1367

alvrs opened this issue Aug 28, 2023 · 1 comment · Fixed by #1544
Assignees
@alvrs
Milestone
v2 contracts stable

Comments

@alvrs
Copy link
Member

alvrs commented Aug 28, 2023

  • resourceSelector is an umbrella term for tableId and systemId.
  • For clarity we should use tableId and systemId in the respective functions that only interact with either of them (eg registerTable vs registerSystem)
  • In remaining places we should rename resourceSelector to resourceId for consistency with tableId and systemId
@alvrs alvrs added this to the Contracts stable milestone Aug 28, 2023
@holic
Copy link
Member

holic commented Aug 28, 2023

Can we add this to the terminology notion doc?

@alvrs alvrs self-assigned this Sep 11, 2023
@alvrs alvrs moved this from Todo to Implementation in MUD v2 stable release (deprecated) Sep 13, 2023
@alvrs alvrs moved this from Implementation to Spec in MUD v2 stable release (deprecated) Sep 13, 2023
@alvrs alvrs moved this from Spec to Todo in MUD v2 stable release (deprecated) Sep 17, 2023
@alvrs alvrs mentioned this issue Sep 19, 2023
Merged
4 tasks
@alvrs alvrs moved this from Planned to In progress in MUD v2 stable release (deprecated) Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvrs alvrs

Labels
None yet
Projects
No open projects
MUD v2 stable release (deprecated)
Status: Done
Milestone
v2 contracts stable
Development

Successfully merging a pull request may close this issue.

feat(store,world): replace ResourceSelector with ResourceId and WorldResourceId latticexyz/mud
2 participants
@holic @alvrs