Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine registration of schema with registration of metadata to have tighter constraints and simplify indexer logic #1043

Closed
Tracked by #760
alvrs opened this issue Jun 16, 2023 · 2 comments · Fixed by #1182

Comments

@alvrs
Copy link
Member

alvrs commented Jun 16, 2023

pulled out from #760

Can we tighten constraints around schema + metadata? i.e. always register key schema + value schema + metadata together (like a regular table), so we can reliably expect them to exist together, and not allow for them to be written more than once. -> yes

@holic
Copy link
Member

holic commented Jun 20, 2023

We chatted earlier, just summarizing here:

Since this change is tightly coupled to things like store-cache, current and future networking code, etc., we decided to punt for a little while longer until the new networking code is complete (leaning on some workarounds for lack of key name, that should hopefully clear up with #1025 and an expanded config).

In the meantime, do we wanna add key names via #1059? Or still not worth the churn? Decided it was too big a change to be worth going through with.

@alvrs
Copy link
Member Author

alvrs commented Jul 19, 2023

closing on in favor of #1122

@alvrs alvrs closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants