-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove app.stub.js #79
Comments
Finally got an index.html wrapper to load in Chrome, surprisingly doesn't solve the problem |
Adding to Karma's static ( <!DOCTYPE html>
<!--
This is the execution context.
Loaded within the iframe.
Reloaded before every execution run.
-->
<html>
<head>
<title></title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no" />
</head>
<body>
<!-- The scripts need to be in the body DOM element, as some test running frameworks need the body
to have already been created so they can insert their magic into it. For example, if loaded
before body, Angular Scenario test framework fails to find the body and crashes and burns in
an epic manner. -->
<script type="text/javascript">
// sets window.__karma__ and overrides console and error handling
// Use window.opener if this was opened by someone else - in a new window
if (window.opener) {
window.opener.karma.setupContext(window);
} else {
window.parent.karma.setupContext(window);
}
// All served files with the latest timestamps
%MAPPINGS%
</script>
<!-- Dynamically replaced with <script> tags -->
%SCRIPTS%
<script type="text/javascript">
window.__karma__.loaded();
</script>
<ion-app></ion-app>
</body>
</html> which is a lot nicer than this fuckery we're doing atm. Just need to figure out how to do that dynamically... |
That's all fine but obviously it hasn't actually been released yet. |
Ready for when Karma release 0.13.23 |
Need to update blog dependencies & files after this |
Awesome work man! :) FYI: I migrated you app to the latest beta6 of ionic because beta4 has an ugly bug and the app does not run on Android (whitescreen only). I hope they'll release Karma asap. |
Ah nice, hopefully someone gets back to you in gitter. Looking at the pattern of their last releases I feel like one should be due now! I didn't know about that bug, will upgrade now.. |
Removed as per 5f096f7 The npm |
Re the previous comment, @lazaromenezes has implemented this correctly in #137 |
This is the last horrible workaround we've got really, should pick it up with the Ionic guys to get to the bottom of it.
The text was updated successfully, but these errors were encountered: