-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull features from angular2 seed #19
Comments
Had a quick look tonight, they have the following:
Ahead of this I've refactored gulpfile.js (now ts!) along the same lines as theirs. |
Taken gulp-inline-ng2-template in 0b6f152, so we don't need to copy html and need less proxying |
When I include moment.js I still get a 404 from Karma using angular2 seed. |
As luck would have it, they've had the exact same issue raised there: So they're using system config instead of proxying in Karma. Seems a bit cleaner.. |
They do in config.ts: // ----------------
// SystemsJS Configuration.
const SYSTEM_CONFIG_DEV = {
defaultJSExtensions: true,
paths: {
[BOOTSTRAP_MODULE]: `${APP_BASE}${BOOTSTRAP_MODULE}`,
'angular2/*': `${APP_BASE}angular2/*`,
'rxjs/*': `${APP_BASE}rxjs/*`,
'*': `${APP_BASE}node_modules/*`
},
packages: {
angular2: { defaultExtension: false },
rxjs: { defaultExtension: false }
}
};
export const SYSTEM_CONFIG = SYSTEM_CONFIG_DEV; And then this in index.html: <% if (ENV === 'dev') { %>
<script>System.config(<%= JSON.stringify(SYSTEM_CONFIG) %>)</script>
<% } %> which is built as part of build.dev.index:
|
Lot of flapping, but it might help us get away from stuff like this |
Seems like a bit of a rabbit hole considering it doesn't give you external deps for free, dropping |
test debug watching working & written up |
Closed in favour of #38 |
See what https://github.com/mgechev/angular2-seed have done since we forked and steal any cool stuff :)
The text was updated successfully, but these errors were encountered: