Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NgRx #128

Closed
lathonez opened this issue Aug 9, 2016 · 4 comments
Closed

Implement NgRx #128

lathonez opened this issue Aug 9, 2016 · 4 comments

Comments

@lathonez
Copy link
Owner

lathonez commented Aug 9, 2016

Follow @JavascriptMick's excellent ngrx presentation, it fits really well with the clickers service

https://github.com/JavascriptMick/ng2-state-talk

@lathonez
Copy link
Owner Author

see #133

@lathonez lathonez mentioned this issue Aug 21, 2016
@lathonez
Copy link
Owner Author

#133 133 has been merged in, but test coverage is woeful / non existent:

-------------------------------|----------|----------|----------|----------|----------------|
File                           |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-------------------------------|----------|----------|----------|----------|----------------|
 app/                          |      100 |      100 |      100 |      100 |                |
  app.ts                       |      100 |      100 |      100 |      100 |                |
  rxjs-operators.ts            |      100 |      100 |      100 |      100 |                |
 app/actions/                  |    84.38 |      100 |    44.44 |       75 |                |
  clicker.ts                   |    84.38 |      100 |    44.44 |       75 |  9,17,24,32,40 |
 app/components/clickerButton/ |      100 |      100 |      100 |      100 |                |
  clickerButton.ts             |      100 |      100 |      100 |      100 |                |
 app/components/clickerForm/   |      100 |      100 |      100 |      100 |                |
  clickerForm.ts               |      100 |      100 |      100 |      100 |                |
 app/effects/                  |    71.88 |      100 |    42.86 |    70.59 |                |
  clicker.ts                   |    71.88 |      100 |    42.86 |    70.59 | 23,24,32,33,40 |
 app/models/                   |    85.71 |      100 |    63.64 |    84.62 |                |
  click.ts                     |      100 |      100 |      100 |      100 |                |
  clicker.ts                   |    77.78 |      100 |    42.86 |    76.47 |    19,23,27,31 |
 app/pages/clickerList/        |    87.88 |      100 |       50 |    81.82 |                |
  clickerList.ts               |    87.88 |      100 |       50 |    81.82 |    33,37,41,45 |
 app/pages/page2/              |    95.45 |      100 |       80 |    90.91 |                |
  page2.ts                     |    95.45 |      100 |       80 |    90.91 |             24 |
 app/reducers/                 |    42.42 |       30 |    33.33 |    35.71 |                |
  clicker.ts                   |    42.42 |       30 |    33.33 |    35.71 |... 56,59,60,61 |
 app/selectors/                |    74.07 |      100 |    53.33 |    68.42 |                |
  clicker.ts                   |    74.07 |      100 |    53.33 |    68.42 |... 29,30,36,42 |
 app/services/                 |    68.84 |    97.75 |       40 |     62.5 |                |
  clickers.ts                  |    88.24 |      100 |       60 |    82.61 |    25,37,43,49 |
  data.ts                      |     43.1 |    93.55 |       15 |    34.15 |... 74,76,78,82 |
  storage.ts                   |     96.3 |      100 |     87.5 |    93.75 |             15 |
  utils.ts                     |    73.68 |      100 |    28.57 |       75 |     8,10,30,34 |
-------------------------------|----------|----------|----------|----------|----------------|
All files                      |    79.46 |    97.08 |    54.62 |    74.27 |                |
-------------------------------|----------|----------|----------|----------|----------------|

@lathonez
Copy link
Owner Author

@lathonez
Copy link
Owner Author

lathonez commented Dec 8, 2016

I'm closing this, I think ngrx detracts from the focus of this repo, which is obviously unit testing.

I should think any ngrx seed project would be easy enough to incorporate into an existing Ionic project.

@lathonez lathonez closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant