Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another problem with var types. #245

Open
proseLA opened this issue Aug 7, 2024 · 0 comments
Open

another problem with var types. #245

proseLA opened this issue Aug 7, 2024 · 0 comments

Comments

@proseLA
Copy link
Contributor

proseLA commented Aug 7, 2024

frequently, when users want to zero something out, they just delete the field so that it is now blank. EO does not handle these situations well at all.

if one blanks out the shipping cost, you get to here:

$shipping_cost = $this->eoRoundCurrencyValue($current_total['value']);

and i have no idea what that method does, but the value starts at blank and it returns a blank value.

so now you update to a blank value here:

$order->info['shipping_cost'] = $shipping_cost;

and then this chokes here:

$shipping_tax = $this->eoRoundCurrencyValue(zen_calculate_tax($order->info['shipping_cost'], $tax_rate));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant