Feature/add data attr to tag api #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test failed as the meta value in the hashes were arrays with elements in different orders. I'm not sure if this matters but the test description makes suggests that perhaps order is important here and this is in fact a real failure. I've left a comment in order to do more investigation at a future point.
This introduces a new feature that enhances the api to accept a data
attribute.
```
meta(
tag_type: {
value: 'value',
data: { 'data-attr-name' => 'data attr value' }
}
)
```
Multiple data attributes can be specified:
```
meta(
tag_type: {
value: 'value',
data: { 'attr-1' => 'one', 'attr-2' => 'two' }
}
)
```
Custom tags can be registered:
```
Metamagic::Renderer.register_tag_type :custom, ->(key, value, data) do
tag(:custom_tag, name: key, value: value, data: data)
end
```
This is backwards compatible with the existing api.
JaredShay
force-pushed
the
feature/add-data-attr-to-tag-api
branch
from
059f974 to
bd67db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This introduces a new feature that enhances the api to accept a data attribute.
Multiple data attributes can be specified:
Custom tags can be registered:
This is backwards compatible with the existing api.
Why was this change introduced?
This change was motivated by the Helmet library which requires that a data attribute be set on meta tags in order for them to be managed client side.