Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already check entry in .gitignore for application.yml #259

Open
tannakartikey opened this issue Feb 10, 2017 · 4 comments
Open

Already check entry in .gitignore for application.yml #259

tannakartikey opened this issue Feb 10, 2017 · 4 comments

Comments

@tannakartikey
Copy link

Currently, even if the application.yml is ignored using .gitignore file, on running bundle exec figaro install, the entry is appended again.

The entry can be present already if you are not the only one in the team and someone started using Figaro before you.

@JStans12
Copy link

JStans12 commented Feb 22, 2017

I looked into this and found that if you have

# Ignore application configuration
/config/application.yml

in your .gitignore, nothing will be appended. However, if you removed either of the two lines, it will append both lines and make the file redundant.

It seems that figaro should really only care about /config/application.yml. I'll put in a PR for this fix.

@tannakartikey
Copy link
Author

We shouldn't hardcode the path also. So it should just care about application.yml

@tannakartikey
Copy link
Author

@laserlemon your views?

@laserlemon
Copy link
Owner

As of today, we should hardcore the path because that's exactly where Figaro will look for it. Thank you for checking on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants