Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mongo db #186

Closed
AhmadWaleed opened this issue Jul 7, 2021 · 5 comments · Fixed by #748
Closed

Support for mongo db #186

AhmadWaleed opened this issue Jul 7, 2021 · 5 comments · Fixed by #748

Comments

@AhmadWaleed
Copy link

I am planning to submit pr with mongo db support, i would like to know if that's something is acceptable in sail?

@driesvints
Copy link
Member

Since Mongodb isn't one of the core supported DB drivers I don't think so.

@WebKenth
Copy link

Since Mongodb isn't one of the core supported DB drivers I don't think so.

@driesvints https://laravel-news.com/mongodb-laravel-integration

While the news site hint's at official integration even though it's just mongodb who took over development/maintaining of the repository integration of mongodb => laravel

Do you mean that the stubs for laravel/sail shouldn't include stubs for other working services and only services like drives the official laravel documentation states?

@bisht2050
Copy link

Hi @driesvints,

My name is Rishabh, and I am the Product Manager at MongoDB, looking after PHP developer experience. I am reaching out to request a reconsideration regarding the addition of MongoDB support to Laravel Sail.

As you may be aware, Laravel's integration with MongoDB has advanced significantly, and we now officially support Laravel. Our commitment to the Laravel community has never been stronger, and I believe that including MongoDB support in Sail will greatly benefit the developers who rely on this tool for their development workflow. To ease any potential concerns, I want to assure you that we are prepared to contribute directly to this effort. Our team is ready to handle the integration work required.

Thank you for considering this request. We look forward to the opportunity to contribute to the Laravel Sail project and to further support the Laravel community.

@taylorotwell
Copy link
Member

Hey @bisht2050! If someone from the Mongo team can PR something I can work to get it merged! 👍

@bisht2050
Copy link

Awesome, thanks Taylor!

PHPORM-208 for tracking purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants