Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & Continue Editing throws error if attempted more than once #1004

Closed
mpenna opened this issue Nov 21, 2018 · 5 comments
Closed

Update & Continue Editing throws error if attempted more than once #1004

mpenna opened this issue Nov 21, 2018 · 5 comments

Comments

@mpenna
Copy link

mpenna commented Nov 21, 2018

  • Laravel Version: 5.6.39
  • Nova Version: 1.1.7
  • PHP Version: PHP 7.2.9-1+ubuntu18.04.1+deb.sury.org+1

Description:

When attempting the "Update & Continue Editing" action a second time around (and for all subsequent attempts), the following error message is shown: "Another user has updated this resource since this page was loaded. Please refresh the page and try again.". As a sidenote, I'm the sole user interacting with the app.

Steps To Reproduce:

Pick any resource, open its Edit view and then try the update & continue editing action more than once. Regardless if any fields have been altered or not, the aforementioned error is thrown.

snag-2018-11-21-12-41-09

@unlikenesses
Copy link

Possibly related to #838

@yehudahkay
Copy link

  • 1

@mislam
Copy link

mislam commented Jul 31, 2019

This is happening when I wait little bit then press update. If I quickly click update within 3-4 seconds, then it updates without any problem. This is a severe issue for us as it significantly slows down our daily business. Need a fix ASAP.

@jbrooksuk
Copy link
Member

I couldn't replicate this in Nova v2.0.9

image

@klimov-paul
Copy link

This is a duplicate of #1082

@jbrooksuk, all steps to reproduce the issue are provided at the description of #1808.
To see the actual error you should manually change times at your clients machine (where browser is launched) to be in the past.
E.g. in case current time at server is '2019-10-16 10:35:00' - the current time at client will be '2019-10-16 10:30:00'.
This will cause timestamp written on model saving at the server side to be ahead of the timestamp generated by JavaScript at the resource retrival. Thus method ResourceUpdateController::modelHasBeenUpdatedSinceRetrieval() will return false causing the 409 error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants