Detail metrics are displayed on related entities views

[chimit]

• Laravel Version: 9.51.0
• Nova Version: 4.22.0
• PHP Version: 8.1.9
• Database Driver & Version:
• Operating System and Version: macOS
• Browser type and version: Safari
• Reproduction Repository: https://github.com/chimit/nova

Description:

My Building resource has a metric that should be displayed only on the detail page. It's a dummy example:

class Building extends Resource
{
    public function cards(NovaRequest $request)
    {
        return [
            (new Metrics\BuildingsPerActive())->onlyOnDetail(),
        ];
    }

But now this metric is also displayed on any Building related resources as well:

Looks like a similar bug to this one.

[crynobone]

I don't think this justifies it as a bug, the previous issue was because it can potentially clash with parent resource's related relationship (Action Events in the example).

Feel free to submit a change request via https://github.com/laravel/nova-issues/discussions/new?category=ideas-feature-requests if you really want this to be changed).

[chimit]

@crynobone @davidhemphill, I tried to simulate quite a realistic situation when multiple metrics on the same page look misleading. Please, check my latest update on https://github.com/chimit/nova

In my example, both Building and Room in that building have renovation dates. They use the same metric (DRY). And in the UI they are hardly distinguishable and confusing. Mostly it's because metrics are displayed above the entity titles. They should at least be shown below.

The second problem is that both these metrics use the same cache and the one which loads later uses the wrong cache. On my example below the second number should have been 88 (based on room renovated_at date, not building renovated_at):

Please, reopen the issue.

[crynobone]

The root cause of your issue is that you are reusing the same Metric with caching without adding a unique identifier (custom uriKey etc).

[chimit]

But this identifier won't help to solve the problem because it's the exact same metric.

[thomasowow]

Currently I am having a similar situation, but instead I do not want the metric to be shown when in the context of a relationship. @chimit how did you solve your problem?