[5.4] Add support to keep old files when testing uploads #19857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gocanto
changed the title
|
Hmm, not sure I really like this boolean option. |
|
Yup, I see what you mean here. I just opened another PR #19859 If not accepted, I would like to know your thohgts in how I can test this use cases. Thanks sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when testing files upload.
Use case:
if you upload a batch of files and then you need to delete just one of them, you will be able to assert that the deleted one does not exist while the others do.
Suggestions are welcome and I will understand if this PR is not accepted.