Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uuid validation rule no longer accepts UUID version 6-7 #48375

Closed
nizacegodk opened this issue Sep 13, 2023 · 1 comment
Closed

Uuid validation rule no longer accepts UUID version 6-7 #48375

nizacegodk opened this issue Sep 13, 2023 · 1 comment
Labels

Comments

@nizacegodk
Copy link

nizacegodk commented Sep 13, 2023

Laravel Version

10.23.0

PHP Version

8.2.4

Database Driver & Version

No response

Description

Since the merge of #48321 the uuid validation rule introduced a breaking change by no longer accepting other versions of UUID than 1-5.

We extensively use version 6 and 7 in our Laravel projects due to some of the benefits these versions supply.

While I do understand the sentiment behind the PR, I think this should be included as either a major release or its own new RfcUuid rule instead to avoid introducing breaking changes in minor releases.

Our systems would break down in its entirety if not for sufficient pipeline testing before releases.
So I suggest reverting the PR and either introducing the change in a major release or as its own seperate rule.

Steps To Reproduce

Create a validator with the uuid rule
Supply the validator with an UUIDv6 created with \Ramsey\Uuid\Uuid::uuid6()->toString()

Notice the failure in Laravel version 10.23.0 and not in 10.22.0

@crynobone crynobone added the bug label Sep 13, 2023
@taylorotwell
Copy link
Member

Reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants