Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed some spaces in some Artisan commands with new look #43543

Closed
sarukomine opened this issue Aug 4, 2022 · 2 comments
Closed

Missed some spaces in some Artisan commands with new look #43543

sarukomine opened this issue Aug 4, 2022 · 2 comments

Comments

@sarukomine
Copy link
Contributor

  • Laravel Version: 9.23.0
  • PHP Version: 8.1.8
  • Database Driver & Version:

Description:

Thanks @nunomaduro for a great work at #43065, I already like it, but I found some places that make me uncomfortable...

The places that the red arrow point at, I think that there should be the additional space.

Screenshot 2022-08-04 at 2 16 39 PM
Screenshot 2022-08-04 at 2 20 48 PM
Screenshot 2022-08-04 at 2 21 31 PM

Steps To Reproduce:

run artisan migrate / artisan migrate:refresh --step=3 --seed / artisan db:seed / artisan migrate:rollback / artisan migrate:fresh

@lk77
Copy link

lk77 commented Aug 4, 2022

I don't see any reason to have a space after the output

@driesvints
Copy link
Member

Not sure I see a real bug here but rather an improvement. Feel free to attempt a PR if you like 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants