Database seeder output is messed up by new Artisan look

[halloei]

• Laravel Version: 9.22.1
• PHP Version: 8.1.8
• Database Driver & Version: MySQL 8.0

Description:

In my database seeders I'm writing output to the console via $this->command->info(). Unfortunately #43065 messed it up:

~$ ./artisan db:seed 

   INFO  Seeding database.  

  Database\Seeders\Users\GroupSeeder ..................................................................................................... 12ms DONE
  Database\Seeders\Users\PermissionSeeder Deleted 0 and created 0 permissions
................................................................................................ 18ms DONE

If you're wondering what I'm doing here: I'm hardcoding the user groups and permissions of my application into seeders. The seeders then keep the database in sync.

Steps To Reproduce:

Create a new seeder an run database seeding:

class TestSeeder extends Seeder
{
    public function run()
    {
        $this->command->info('Lorem ipsum');
    }
}

[ankurk91]

It is not just seeder, we are running artisan command inside migrations via Artisan:call, and if artisan command outputs something, it mess up existing output.

<?php

return new class extends Migration {
   
    public function up()
    {
        Artisan::call(CampaignConfigurationMigrationCommand::class, [
            '--force' => true,
        ], new ConsoleOutput());
    }

};

One way to fix it by using new component intruduce recently.

[ankurk91]

[nunomaduro]

@ankurk91 With the console output improvements, we don't really expect "output" in the middle of seeders. Same goes when calling Artisan::call( within seeders, can you consider running that command discarding the output?

[ankurk91]

One can do like

<?php

class DatabaseSeeder extends Seeder
{
   
    public function run()
    {
        // So laravel team does not recommand to do this in seeders?
        $this->command->info('Importing huge data from csv');
  
        Artisan::call(ImportCSVCommand::class, [
            'file' => database_path('raw/huge-csv.csv'),
            '--force' => true,
        ], $this->command->getOutput()); // We should not supply the last argument here? 

  }

I have tried to remove the last parameter from Artisan::call, but now it does not show any output form artisan command.
The artisan command has lines like

$this->line(now().' Starting file import ...');

which we want to append on the terminal when running from seeder. we have been doing this from years already.

we don't really expect "output" in the middle of seeders.

Then we should also deprecate the $this->command in seeder

[halloei]

@nunomaduro Doesn't sound like an improvement, at least for me.

Wouldn't it be possible to display the output similar to ./artisan route:list --verbose?

The rows that are used to display the middleware (groups) here could be our output instead.

I think this would be a useful addition as there are likely other use cases in the future.

[ankurk91]

ping @nunomaduro
We have not heard from you.

[nunomaduro]

We are going to address this issue soon.