Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] calling Collection::implode('_') throws error #41466

Closed
taka-oyama opened this issue Mar 14, 2022 · 1 comment · Fixed by #41468
Closed

[9.x] calling Collection::implode('_') throws error #41466

taka-oyama opened this issue Mar 14, 2022 · 1 comment · Fixed by #41468
Labels
bug

Comments

@taka-oyama
Copy link
Contributor

taka-oyama commented Mar 14, 2022 •
edited
Loading

  • Laravel Version: 9.x-dev
  • PHP Version: 8.0.16

Description:

The following pull request broke parts of our code.
#41405

Steps To Reproduce:

collect([1,2,3])->implode('_')

Throws the following error.

_() expects exactly 1 argument, 2 given

This is because '_' is a function defined by the gettext extension.

Checking with is_callable is probably not suitable here.
@taka-oyama taka-oyama changed the title [9.x] calling implode('_') throws error [9.x] calling Collection::implode('_') throws error Mar 14, 2022
@derekmd derekmd mentioned this issue Mar 14, 2022
Merged
@driesvints driesvints added the bug label Mar 14, 2022
@driesvints driesvints mentioned this issue Mar 14, 2022
Merged
@eusonlito
Copy link
Contributor

Fix PR pending to merge #41468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[9.x] Fix Collection::implode() string argument derekmd/framework
3 participants
@driesvints @eusonlito @taka-oyama