Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] assertArraySubset deprecated in PHPUnit 8 #27550

Closed
GrahamCampbell opened this issue Feb 16, 2019 · 2 comments
Closed

[5.8] assertArraySubset deprecated in PHPUnit 8 #27550

GrahamCampbell opened this issue Feb 16, 2019 · 2 comments

Comments

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Feb 16, 2019

Either we need to convince PHPUnit to revert this, or find a replacement, otherwise test code using Illuminate\Foundation\Testing\TestResponse::assertJson will start to throw deprecation warnings.


Relates to sebastianbergmann/phpunit#3494. // cc @driesvints

@driesvints
Copy link
Member

driesvints commented Feb 17, 2019

No worries. I already took care of this in #27441. I've committed 695a299 which overwrites the method to prevent the warnings. I couldn't take over the full ArraySubset class because the method signature on the Constraint base class was changed and thus it will only work on either PHPUnit 7 or below or PHPUnit 8 or above. We'll take over the full class as soon as we're dropping support for PHPUnit 7 and add support for PHPUnit 9 in February next year.

@driesvints
Copy link
Member

Thanks for mentioning btw! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants