Fully support Request::validate method in IDE

[denirun]

• Laravel Version: 5.5.26
• PHP Version: 7.1.11
• Database Driver & Version: -

Description:

IDE not fully support Illuminate\Http\Request::validate autocomplete for object instances.

Steps To Reproduce:

When you using barryvdh/laravel-ide-helper library, and try call \Request::validate() all works perfectly.

When you have instance of Illuminate\Http\Request class and try to call method validate IDE don't see implementation of this method.

Can you please fix this annoying small problem.

public function index(\Illuminate\Http\Request $request): View
{
       // All good
      \Request::validate();

       // Method 'validate' not found
	$request->validate([
	    'name' => 'required',
	]);
}

[LKaemmerling]

This should go to barryvdh/laravel-ide-helper's repository and isn't an issue from laravel itself.

[denirun]

No! You are not right! If you write like this

$request = new \Illuminate\Http\Request();
$request->validate();

Does your IDE see method validate() ?
Strange but my not, also i checked this class, and all traits and there is no implementation of validate method. Please add this!

[devcircus]

'validate' is implemented as a macro on request in the core, here. FoundationServiceProvider.

Seems @LKDevelopment is correct. Don't really see another way.

[denirun]

Thanks @devcircus i get it now. My opinion validate it's very good syntax sugar to place inside Request class. Code much smaller and elegant. But idea to make it via macros and fully lost autocomplete with check implementation, phpdoc and e.t.c..... very controversial. I personally don't like "magical", but if no way to fix this... sad :-(

[devcircus]

True. Still confused by this. I don't know of any other macros used in the core but I can't help but think that maybe there was a good reason for implementing it this way. Maybe worth opening an issue on the internals repo to discuss?

[rs-sliske]

#19063 (comment)

[devcircus]

Makes sense! Thanks.