Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabaseSessionHandler::read() must return empty string instead of null #21276

Closed
RomeroMsk opened this issue Sep 20, 2017 · 2 comments
Closed

Comments

@RomeroMsk
Copy link

  • Laravel Version: 5.5.2
  • PHP Version: 7.1.9
  • Database Driver & Version: pgsql

Description:

According to PHP manual, \Illuminate\Session\DatabaseSessionHandler::read() must return an empty string if nothing was read. Now it returns null in case of expired session or when payload is not set. It entails a warning:

session_start(): Failed to read session data
@themsaid
Copy link
Member

Addressed in #21277

Thanks

@RomeroMsk
Copy link
Author

@themsaid, thanks for the fast reply! But you also need to add return '' in the end of this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants