Cache::many returns incorrect defaults

[Dadibom]

• Laravel Version: 5.4.19
• PHP Version: 7.0.15
• Database Driver & Version: phpredis

Description:

Default values are only applied to null keys, not non-existing keys

Steps To Reproduce:

Cache::put('keyThatIsNull', null, 1);
dd(Cache::many([
    'keyThatIsNull' => 'You will see this string',
    'keyThatDoesNotExist' => 'But this default value does not work, you\'ll get false instead',
]));

output:

array:2 [
  "keyThatIsNull" => "You will see this string"
  "keyThatDoesNotExist" => false
]

[themsaid]

Where did you get this? many() accepts an array of keys with no default values.

[Dadibom]

since it wasn't in the docs for cache, I had to look through the source. Check out line 124:
https://github.com/illuminate/cache/blob/master/Repository.php

[themsaid]

I see now, but I can't replicate your issue:

\Cache::put('keyThatIsNull', null, 1);
    
    dd(\Cache::many([
        'keyThatIsNull' => 'You will see this string',
        'keyThatDoesNotExist' => 'But this default value does not work, you\'ll get false instead',
    ]));

The results is:

array:2 [▼
  "keyThatIsNull" => "You will see this string"
  "keyThatDoesNotExist" => "But this default value does not work, you'll get false instead"
]

[Dadibom]

Are you using phpredis?

[themsaid]

Ok I've opened a PR with a fix: #18984

Thanks :)

[Dadibom]

Thanks!