It seams i cannot use $tries and $timeout properties on my queued listener class?

[peyobr]

• Laravel Version: 5.4.15
• PHP Version: 7.0
• Database Driver & Version: yajra/laravel-pdo-via-oci8
• Queue Driver: Beanstalkd

Description:

It seams i cannot use $tries and $timeout properties on my queued listener class?

I'm doing something wrong?

Thank you.

peyobr

Steps To Reproduce:

[sisve]

We're missing steps to reproduce and an actual error description. Do you get an error message?

[peyobr]

Hi, no error message. Simply:

1. generate an event-listener pair
2. add ShouldQueue interface on listener
3. add $tries and $timeout properties on listener
4. fire the event with the event() helper

Inspect queued listener using beanstalkd console and you'll notice that 'timeout' and 'maxTries' are stored as null.

If i use queued Job instead everything is ok!

Thanks.

[sisve]

I see nothing in the code that states that events should support $tries or $timeout. Reference:

framework/src/Illuminate/Events/Dispatcher.php

Lines 434 to 462 in 35f0bb1

	protected function callQueueMethodOnHandler($class, $method, $arguments)
	{
	$handler = (new ReflectionClass($class))->newInstanceWithoutConstructor();
	$handler->queue($this->resolveQueue(), 'Illuminate\Events\CallQueuedHandler@call', [
	'class' => $class, 'method' => $method, 'data' => serialize($arguments),
	]);
	}
	/**
	* Queue the handler class.
	*
	* @param string $class
	* @param string $method
	* @param array $arguments
	* @return void
	*/
	protected function queueHandler($class, $method, $arguments)
	{
	$listener = (new ReflectionClass($class))->newInstanceWithoutConstructor();
	$connection = isset($listener->connection) ? $listener->connection : null;
	$queue = isset($listener->queue) ? $listener->queue : null;
	$this->resolveQueue()
	->connection($connection)
	->pushOn($queue, new CallQueuedListener($class, $method, $arguments));
	}

Are you saying that something in the docs says they should; or are you asking for a new feature?

[peyobr]

You are right. I have assumed that new granular approach would be available in listener too.

I hope this will be in the near future!

Thank you!

[themsaid]

Just submitted a PR that should add the functionality #18375

[peyobr]

Thank you 1K!