[5.4] Reset password loses old input

[tylercubell]

• Laravel Version: 5.4.0
• PHP Version: 7.1
• Database Driver & Version: N/A

Description:

Old input data isn't being preserved.

SendsPasswordResetEmails@sendResetLinkFailedResponse should match ResetsPasswords@sendResetFailedResponse and use:

return redirect()->back()
            ->withInput($request->only('email'))
            ->withErrors(['email' => trans($response)]);

instead of this:

return back()->withErrors(
    ['email' => trans($response)]
);

Also, I don't understand how ResetsPasswords@showResetForm gets email when the route looks like:

$this->get('password/reset/{token}', 'Auth\ResetPasswordController@showResetForm')->name('password.reset');

public function showResetForm(Request $request, $token = null)
{
    return view('auth.passwords.reset')->with(
        ['token' => $token, 'email' => $request->email]
    );
}

Also, ForgotPasswordController should have:

protected $redirectTo = '/home';

since it also redirects like LoginController and RegisterController.

Also, the password reset email escapes <br> after Regards,.

I don't know exactly what's happening with #17499 so I didn't make a PR for this.

[jerguslejko]

It's usually better to submit these things as a PR.

Also, you can access query string params through the request object.

/password/reset/XXXXX?email=hello 

can be accessed like this:

$request->email

[jafar690]

@tylercubell just overide the sendResetLinkFailedResponse function in the ForgotPasswordController like this

    /**
     * Get the response for a failed password reset link.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  string  $response
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    protected function sendResetLinkFailedResponse(Request $request, $response)
    {
        return back()->withErrors(
            ['email' => trans($response)]
        )->withInput(\Input::all());
    }