Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-source support for updateSiteDeploymentScript Method #169

Closed
mehrancodes opened this issue Oct 3, 2023 · 1 comment
Closed
Assignees

Comments

@mehrancodes
Copy link

In order to enhance the deployment process and provide more flexibility, we need to add the ability to make .env variables available to the deployment script in the forge-sdk. This can be achieved by adding a fourth boolean argument to the updateSiteDeploymentScript method.

Current Behavior:
Currently, the method signature is:

$service->forge->updateSiteDeploymentScript($serverId, $siteId, $content);

Desired Behavior:
The proposed method signature is:

$service->forge->updateSiteDeploymentScript($serverId, $siteId, $content, $autoSource);

Where $autoSource is a boolean indicating whether to automatically source the .env variables.

@jbrooksuk
Copy link
Member

This was done in #167 and is available in https://github.com/laravel/forge-sdk/releases/tag/v3.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants