Fix assertValue for select elements #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I missed this. Do you think |
|
@u01jmg3 yeah I think that makes sense. Feel free to PR 👍 |
|
@driesvints: hmm, so Taylor closed my PR. Not sure what the best course of action is. Currently it seems like having this PR merged but my one closed is inconsistent for selects. I realise there have been a lot of reverted PRs on laravel/framework recently which has resulted in super caution. |
|
What issue led to this PR being opened? Might help with raising a new PR for the one that got closed |
|
Let's just leave things be for now. |
|
No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.