[6.x] Support waiting for URLs with waitForLocation
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my projects has a model that returns a dynamic URL. In my test, I want Dusk to click a link, and then wait for that location. The test looks something like this:
The code above doesn't work, because
$model->detail_page_urlreturns a full URL, butwaitForLocationcan only wait for paths (/some-path). This PR updateswaitForLocationso it can also wait for full URLs. There is currently no method to wait for a URL.I've chosen to use
${location.protocol}//${location.host}${location.pathname}to get the current URL (taken from this StackOverflow answer). This way query parameters and fragment identifiers (#) in the current URL are ignored.