Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add purge console command #887

Merged
merged 4 commits into from
Mar 23, 2021
Merged

[6.x] Add purge console command #887

merged 4 commits into from
Mar 23, 2021

Conversation

crynobone
Copy link
Member

image

Purging when folder doesn't exist.

image

Signed-off-by: Mior Muhammad Zaki [email protected]

@taylorotwell
Copy link
Member

So we don't want to purge everytime you run dusk anymore?

@crynobone
Copy link
Member Author

@taylorotwell on dusk, it will silently call dusk:purge

@driesvints
Copy link
Member

I realized that technically there are breaking changes here since the protected methods in the Dusk command are now gone. We'll need to be aware of that.

@crynobone
Copy link
Member Author

@driesvints ahhh yeah, we could revert DuskCommand changes and only add the new command for 6.x

@taylorotwell
Copy link
Member

@crynobone sounds good

Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
Copy link
Member Author

@driesvints @taylorotwell done.

Signed-off-by: Mior Muhammad Zaki <[email protected]>
@taylorotwell taylorotwell merged commit 002226d into laravel:6.x Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants