[6.x] Add support for Mac ARM64 architecture #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
commented
Feb 16, 2021
| default: | ||
| return 'mac'; | ||
| } | ||
| } |
There was a problem hiding this comment.
This different from PR sent to master. Instead of having onMacIntel() and onMacArm() we can just stick with onMac() and then have a new method to return architecture value.
crynobone
commented
Feb 16, 2021
| @@ -59,6 +59,8 @@ class ChromeDriverCommand extends Command | |||
| protected $slugs = [ | |||
| 'linux' => 'linux64', | |||
| 'mac' => 'mac64', | |||
| 'mac-intel' => 'mac64', | |||
| 'mac-arm' => 'mac64_m1', | |||
There was a problem hiding this comment.
mac key will remain for fallback in case architecture value doesn't match x86_64 or arm64.
|
@crynobone this looks good to me 👍 @sirdharma can you give this a review? We're planning on introducing ARM64 support on Dusk 6.x so we can delay Dusk 7.x until PHPUnit 10 is released. |
taylorotwell
pushed a commit
that referenced
this pull request
Feb 16, 2021
* Refactor PR to match changes to 6.x Signed-off-by: Mior Muhammad Zaki <[email protected]> * Allow tests on phpunit 10. Signed-off-by: Mior Muhammad Zaki <[email protected]> * Skip testbench 5. Signed-off-by: Mior Muhammad Zaki <[email protected]>
|
@driesvints LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mior Muhammad Zaki [email protected]