New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix DuskCommand syntax mistake #871

Merged

driesvints merged 1 commit into laravel:6.x from derekmd:fix-ci-typo

Feb 12, 2021

Contributor

derekmd commented Feb 12, 2021

Now that I've actually tested the --browse feature in a sample app, fix a stupid syntax error I introduced in: #870

It would be good to get test coverage on DuskCommand but it may require:

disabling $this->withDuskEnvironment()
using Mockery static namespace overloading (eh) because the Symfony\Component\Process\Process object isn't resolved from Laravel's container.


          Fix DuskCommand syntax mistake

No test coverage, you say.

driesvints approved these changes

View reviewed changes

driesvints merged commit 18ec57d into laravel:6.x

Member

driesvints commented Feb 12, 2021

Thanks

derekmd deleted the fix-ci-typo branch

February 12, 2021 21:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet