[6.x] Add Vue 3 support to the assertVue*() methods #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmd
force-pushed
the
vue-3-support
branch
from
28ce6ff to
783fdd6
Compare
Vue 3 no longer adds a __vue__ property to DOM nodes to allow querying for props. Instead the __vueParentComponent must be inspected. Its 'ctx' property will return the: * passed in component props * data() * computed props When Dusk is looking up the Vue prop value of a DOM node, it will first look for a Vue 2 __vue__ property, then fallback to __vueParentComponent.ctx for Vue 3.
derekmd
force-pushed
the
vue-3-support
branch
from
783fdd6 to
873f517
Compare
|
This would have been hard to figure out on my own. Thank you ❤️ |
|
Thanks @derekmd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #832
Vue 3 no longer adds a
__vue__property to DOM nodes to allow querying for props. Instead the__vueParentComponentmust be inspected. Its 'ctx' property is an object containing the:data()defined within the componentThe above three items would be checked by Laravel Dusk to assert
v-modelvalue bindings.When Dusk is looking up the Vue prop value of a DOM node, it will first look for a Vue 2
__vue__property, then fallback to__vueParentComponent.ctxfor Vue 3.