Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Add assertScript() #821

Merged
merged 1 commit into from
Sep 29, 2020
Merged

[6.x] Add assertScript() #821

merged 1 commit into from
Sep 29, 2020

Conversation

nuernbergerA
Copy link
Contributor

This PR adds the ability to make assertions against JavaScript with assertScript()

It always ensures that the expression is prefixed with return and expects a truthy result

For different expectations, the 2nd parameter can be passed.

Realworld use cases from livewire

@taylorotwell taylorotwell merged commit 12e4533 into laravel:6.x Sep 29, 2020
@nuernbergerA nuernbergerA deleted the assert-script branch September 30, 2020 10:43
@u01jmg3 u01jmg3 mentioned this pull request Oct 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuernbergerA @taylorotwell