Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fixed proxy for getting latest version #805

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

markuskoehler
Copy link
Contributor

No description provided.

@driesvints
Copy link
Member

Can you please give a bit more info here?

@driesvints driesvints changed the title fixed proxy for getting latest version [6.x] Fixed proxy for getting latest version Sep 4, 2020
@markuskoehler
Copy link
Contributor Author

This fixes the implementation of the proxy flag. The proxy was considered for pulling the binary, but not for pulling the latest version. Due to the version being fetched first, ChromeDriver Command failed behind a corporate proxy.

@taylorotwell taylorotwell merged commit 4327475 into laravel:6.x Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants