Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Adds typeWithPauses(), appendWithPauses() methods #748

Merged
merged 3 commits into from
Mar 14, 2020

Conversation

hivokas
Copy link
Contributor

@hivokas hivokas commented Mar 13, 2020

These methods allow you to type/append the values to the fields with pauses.

After the merging of this PR you'll be able to replace this:

->tap(function (Browser $browser) {
    foreach (str_split('+1 (202) 555-5555') as $char) {
        $browser->append('mobile', $char)->pause(100);
    }
})

With this:

->typeWithPauses('mobile', '+1 (202) 555-5555')

Motivation: #558 (comment)

@taylorotwell
Copy link
Member

Maybe typeSlowly and appendSlowly

@hivokas
Copy link
Contributor Author

hivokas commented Mar 13, 2020

@taylorotwell sounds good

@hivokas
Copy link
Contributor Author

hivokas commented Mar 13, 2020

@taylorotwell I've updated the PR

@taylorotwell taylorotwell merged commit afd6c71 into laravel:5.0 Mar 14, 2020
@driesvints
Copy link
Member

@hivokas can you maybe PR these to the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants