Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Improve detection of latest stable ChromeDriver release #677

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

staudenmeir
Copy link
Contributor

By default, php artisan dusk:chrome-driver downloads the latest stable ChromeDriver release. We are currently parsing http://chromedriver.chromium.org to get the version number, but that's not ideal. When the HTML changes (as it did last week), it breaks the updater (#672).

https://chromedriver.storage.googleapis.com/LATEST_RELEASE does contain this version number, but the file had been deprecated for the last months. I explained our issue to the ChromeDriver team and they removed the deprecation: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3128

@taylorotwell taylorotwell merged commit 7cc0e7f into laravel:5.0 Sep 16, 2019
@staudenmeir staudenmeir deleted the chromedriver branch September 16, 2019 18:01
@driesvints
Copy link
Member

Thanks. I'll do a release for this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants