[5.0] Add proxy support to the 'dusk:install' command #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently 'php artisan dusk:install' fails if you are behind a proxy. This commit adds two new options: --proxy= - e.g. "--proxy=tcp://127.0.0.1:9000" - is passed to file_get_contents() via stream context --ssl-no-verify - skips SSL certificate verification; useful when the proxy replaces the original SSL certificate with it's own for HTTPS traffic inspection
driesvints
changed the title
|
Should we also support proxies with authentication? |
staudenmeir
reviewed
Jul 8, 2019
staudenmeir
reviewed
Jul 8, 2019
staudenmeir
reviewed
Jul 8, 2019
Co-Authored-By: Jonas Staudenmeir <[email protected]>
staudenmeir
reviewed
Jul 8, 2019
staudenmeir
reviewed
Jul 8, 2019
…to add-proxy-support
Co-Authored-By: Jonas Staudenmeir <[email protected]>
Co-Authored-By: Jonas Staudenmeir <[email protected]>
…to add-proxy-support
staudenmeir
reviewed
Jul 8, 2019
staudenmeir
reviewed
Jul 8, 2019
I'm not sure how complicated it can get to implement (there are various types of proxy auth). Also,
Bye |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
php artisan dusk:installfails behind a proxy.This commit adds two new options:
--proxy=PROXY_ADDRESS- e.g.--proxy=tcp://127.0.0.1:9000, the address gets passed tofile_get_contents()via stream context--ssl-no-verify- skips SSL certificate verification byfile_get_contents(); useful when the proxy replaces the original SSL certificate with it's own for HTTPS traffic inspection. In that case thedusk:installcommand fails:PS: I could not test this commit without a proxy! Please test the defaults (no proxy) before merging.