New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] Fix cookies with falsey values #617

Merged

taylorotwell merged 1 commit into laravel:5.0 from staudenmeir:cookie

Feb 28, 2019

Contributor

staudenmeir commented Feb 28, 2019

The loose comparison doesn't work with falsey values like 0 or '':

$browser->cookie('foo', 0); // Gets the cookie instead of setting it.


          Fix cookies with falsey values

a645531

driesvints approved these changes

View reviewed changes

taylorotwell merged commit 3f6312a into laravel:5.0

staudenmeir deleted the cookie branch

February 28, 2019 21:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet