#934 - throw an error if assertValue() / assertValueIsNot() are u…

…sed with an element that does not support the `value` attribute
laravel · Oct 12, 2021 · 97cb71d · 97cb71d
1 parent 696a641
commit 97cb71d
Show file tree

Hide file tree

Showing 2 changed files with 90 additions and 4 deletions.
diff --git a/src/Concerns/MakesAssertions.php b/src/Concerns/MakesAssertions.php
@@ -649,7 +649,15 @@ public function assertValue($selector, $value)
     {
         $fullSelector = $this->resolver->format($selector);
 
-        $actual = $this->resolver->findOrFail($selector)->getAttribute('value');
+        $element = $this->resolver->findOrFail($selector);
+        $tagName = $element->getTagName();
+
+        PHPUnit::assertTrue(
+            $tagName === 'textarea' || $this->supportsTheValueAttribute($tagName),
+            __FUNCTION__." cannot be used with the element [{$fullSelector}]."
+        );
+
+        $actual = $element->getAttribute('value');
 
         PHPUnit::assertEquals(
             $value,
@@ -671,7 +679,15 @@ public function assertValueIsNot($selector, $value)
     {
         $fullSelector = $this->resolver->format($selector);
 
-        $actual = $this->resolver->findOrFail($selector)->getAttribute('value');
+        $element = $this->resolver->findOrFail($selector);
+        $tagName = $element->getTagName();
+
+        PHPUnit::assertTrue(
+            $tagName === 'textarea' || $this->supportsTheValueAttribute($tagName),
+            __FUNCTION__." cannot be used with the element [{$fullSelector}]."
+        );
+
+        $actual = $element->getAttribute('value');
 
         PHPUnit::assertNotEquals(
             $value,
@@ -682,6 +698,28 @@ public function assertValueIsNot($selector, $value)
         return $this;
     }
 
+    /**
+     * Determine if the given element supports the 'value' attribute.
+     *
+     * @param  string  $tagName
+     * @return bool
+     */
+    public function supportsTheValueAttribute($tagName)
+    {
+        return in_array(
+            $tagName,
+            [
+                'button',
+                'input',
+                'li',
+                'meter',
+                'option',
+                'param',
+                'progress',
+            ]
+        );
+    }
+
     /**
      * Assert that the element matching the given selector has the given value in the provided attribute.
      *

diff --git a/tests/MakesAssertionsTest.php b/tests/MakesAssertionsTest.php
@@ -457,11 +457,12 @@ public function test_assert_select_missing_option_and_option_empty()
         $browser->assertSelectMissingOption('select[name="users"]', 1);
     }
 
-    public function test_assert_value()
+    public function test_assert_value_using_supported_element()
     {
         $driver = m::mock(stdClass::class);
 
         $element = m::mock(RemoteWebElement::class);
+        $element->shouldReceive('getTagName')->andReturn('textarea');
         $element->shouldReceive('getAttribute')->andReturn('bar');
 
         $resolver = m::mock(stdClass::class);
@@ -482,11 +483,12 @@ public function test_assert_value()
         }
     }
 
-    public function test_assert_value_is_not()
+    public function test_assert_value_is_not_using_supported_element()
     {
         $driver = m::mock(stdClass::class);
 
         $element = m::mock(RemoteWebElement::class);
+        $element->shouldReceive('getTagName')->andReturn('meter');
         $element->shouldReceive('getAttribute')->andReturn('bar');
 
         $resolver = m::mock(stdClass::class);
@@ -507,6 +509,52 @@ public function test_assert_value_is_not()
         }
     }
 
+    public function test_assert_value_using_unsupported_element()
+    {
+        $driver = m::mock(stdClass::class);
+
+        $element = m::mock(RemoteWebElement::class);
+        $element->shouldReceive('getTagName')->andReturn('p');
+
+        $resolver = m::mock(stdClass::class);
+        $resolver->shouldReceive('format')->with('foo')->andReturn('body foo');
+        $resolver->shouldReceive('findOrFail')->with('foo')->andReturn($element);
+
+        $browser = new Browser($driver, $resolver);
+
+        try {
+            $browser->assertValue('foo', 'bar');
+        } catch (ExpectationFailedException $e) {
+            $this->assertStringContainsString(
+                'assertValue cannot be used with the element [body foo].',
+                $e->getMessage()
+            );
+        }
+    }
+
+    public function test_assert_value_is_not_using_unsupported_element()
+    {
+        $driver = m::mock(stdClass::class);
+
+        $element = m::mock(RemoteWebElement::class);
+        $element->shouldReceive('getTagName')->andReturn('div');
+
+        $resolver = m::mock(stdClass::class);
+        $resolver->shouldReceive('format')->with('foo')->andReturn('body foo');
+        $resolver->shouldReceive('findOrFail')->with('foo')->andReturn($element);
+
+        $browser = new Browser($driver, $resolver);
+
+        try {
+            $browser->assertValueIsNot('foo', 'foo');
+        } catch (ExpectationFailedException $e) {
+            $this->assertStringContainsString(
+                'assertValueIsNot cannot be used with the element [body foo].',
+                $e->getMessage()
+            );
+        }
+    }
+
     public function test_assert_attribute()
     {
         $driver = m::mock(stdClass::class);